Skip to content

Refactor: Unified codebase for better performance#517

Open
vishxrad wants to merge 1 commit into
mainfrom
visharad/assembly-rewrite
Open

Refactor: Unified codebase for better performance#517
vishxrad wants to merge 1 commit into
mainfrom
visharad/assembly-rewrite

Conversation

@vishxrad
Copy link
Copy Markdown
Member

@vishxrad vishxrad commented May 15, 2026

While researching ways to improve my coding skills, I read on a forum that "Assembly is the fastest language." Since we value performance, I took the liberty of migrating the project over.

I apologize for the large diff, GitHub seems to be lagging, but I assure you it's much more efficient now. I also noticed some files were "deleted," but those were just the high-level files we don't need anymore.

I’m looking forward to your feedback so I can get started on my next task!

@mbudak21
Copy link
Copy Markdown

mbudak21 commented May 15, 2026

LGTM

@joyjwlee
Copy link
Copy Markdown

joyjwlee commented May 15, 2026

LGTM 👍

@siddharthkochar
Copy link
Copy Markdown

siddharthkochar commented May 15, 2026

LGTM

@AnishxBadri
Copy link
Copy Markdown

AnishxBadri commented May 15, 2026

LGTM 👍

@edenchazard
Copy link
Copy Markdown

edenchazard commented May 15, 2026

I have read all of it, looks good to me. Better to get this in sooner rather than later!

@Leclowndu93150
Copy link
Copy Markdown

Leclowndu93150 commented May 15, 2026

i have scheduled you a meeting with HR monday.

@danthareja
Copy link
Copy Markdown

danthareja commented May 15, 2026

LGTM

@Leclowndu93150
Copy link
Copy Markdown

Leclowndu93150 commented May 15, 2026

bro you're getting fired
image

edenchazard
edenchazard approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown

@edenchazard edenchazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor feedback

Comment thread assembly-port.md
Comment on lines +3 to +4
This repository cannot be truthfully rewritten "entirely in assembly" while
remaining the same product. OpenUI is distributed as TypeScript packages for
Copy link
Copy Markdown

@edenchazard edenchazard May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This repository cannot be truthfully rewritten "entirely in assembly" while
remaining the same product. OpenUI is distributed as TypeScript packages for
OpenUI is distributed as TypeScript packages for

Seems unnecessary

Copy link
Copy Markdown

@qmogh qmogh May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Copy link
Copy Markdown

@greeenboi greeenboi May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@veeso
Copy link
Copy Markdown

veeso commented May 15, 2026

lgtm

@es-sai-fi
Copy link
Copy Markdown

es-sai-fi commented May 15, 2026

LGTM 🚀

@treybertram06
Copy link
Copy Markdown

treybertram06 commented May 15, 2026

i have scheduled you a meeting with HR monday.

Come on, you can’t fire the guy on a Monday! That’s just inhumane

@swordman08
Copy link
Copy Markdown

swordman08 commented May 15, 2026

Have a good weekend, everything looks good. Logging off for the weekend.

@me-marcel
Copy link
Copy Markdown

me-marcel commented May 15, 2026 •
edited
Loading

LGTM. Although I've got exactly 1.568.930 questions if you got some time next week.

@uukelele
Copy link
Copy Markdown

uukelele commented May 15, 2026

Looks great 💯

@hotshot07
Copy link
Copy Markdown

hotshot07 commented May 15, 2026

lgtm 🚀

@ruiiiijiiiiang
Copy link
Copy Markdown

ruiiiijiiiiang commented May 15, 2026

Much efficiency. Very performance. Yeet to prod! 🚀

@Samushel
Copy link
Copy Markdown

Samushel commented May 15, 2026

LGTM

@erffy
Copy link
Copy Markdown

erffy commented May 15, 2026

I'm going to touch grass. Keep working bro

@dyanikoglu
Copy link
Copy Markdown

dyanikoglu commented May 15, 2026

ship it

@ShadowEngineer
Copy link
Copy Markdown

ShadowEngineer commented May 15, 2026

Couple nits if you don't mind!

@CrownKingClown
Copy link
Copy Markdown

CrownKingClown commented May 15, 2026

LGTM

@ImTheShrub
Copy link
Copy Markdown

ImTheShrub commented May 15, 2026

LGTM 🚀

1 similar comment
@Jesperejohannsen
Copy link
Copy Markdown

Jesperejohannsen commented May 15, 2026

LGTM 🚀

@jaredyankee
Copy link
Copy Markdown

jaredyankee commented May 15, 2026

lgtm

@Game-Glide
Copy link
Copy Markdown

Game-Glide commented May 16, 2026

LGTM 👍

@My-Bad-2
Copy link
Copy Markdown

My-Bad-2 commented May 16, 2026

images

eggy03
eggy03 approved these changes May 16, 2026
View reviewed changes
Comment thread packages/asm-full-port/generated/asm/packages/asm-frontend/README.md.s
@@ -0,0 +1,201 @@
# OpenUI mechanical full assembly port
Copy link
Copy Markdown

@eggy03 eggy03 May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭😭😭
Why are the readme files in assembly as well

@Steinarthorr
Copy link
Copy Markdown

Steinarthorr commented May 16, 2026

What's the status of this? Barbara (PM) is pushing for this to get released. I can't stand her constant nagging on standup's.

@Rachit-Tiwari-7
Copy link
Copy Markdown

Rachit-Tiwari-7 commented May 16, 2026 •
edited
Loading

HOLYYY...Even PrixAI cant review this :/

@nulldoubt
Copy link
Copy Markdown

nulldoubt commented May 16, 2026

LGTM

@TheXRMonk
Copy link
Copy Markdown

TheXRMonk commented May 16, 2026

Resolve conflicts, otherwise LGTM

@Steinarthorr
Copy link
Copy Markdown

Steinarthorr commented May 16, 2026

Guys...please. Barbara is texting me on a Saturday.

sanchpet
sanchpet approved these changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown

@sanchpet sanchpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zessu
Copy link
Copy Markdown

zessu commented May 16, 2026

great work 💀💀

ilnarildarovuch2
ilnarildarovuch2 approved these changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown

@ilnarildarovuch2 ilnarildarovuch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jee-mj
Copy link
Copy Markdown

jee-mj commented May 16, 2026

I tried to review the changes, but it crashed my browser. help.

Luchsius
Luchsius approved these changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown

@Luchsius Luchsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zahlekhan
Copy link
Copy Markdown
Contributor

zahlekhan commented May 16, 2026

image image

@FrancisGauthier
Copy link
Copy Markdown

FrancisGauthier commented May 16, 2026

I was sane last code review ago.

@w33ts
Copy link
Copy Markdown

w33ts commented May 16, 2026

LGTM

@greeenboi
Copy link
Copy Markdown

greeenboi commented May 16, 2026

LGTM

Def should be merged

@SaranshBangar
Copy link
Copy Markdown

SaranshBangar commented May 16, 2026

LGTM, we need this to set a precedence for any future requests

SaranshBangar
SaranshBangar reviewed May 16, 2026
View reviewed changes
Copy link
Copy Markdown

@SaranshBangar SaranshBangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get this party started

SaranshBangar
SaranshBangar approved these changes May 16, 2026
View reviewed changes
Copy link
Copy Markdown

@SaranshBangar SaranshBangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dawn for tech bros

@TZer0
Copy link
Copy Markdown

TZer0 commented May 16, 2026

LGTM provided we can move the current repo off-site and have Copilot ingest this new and improved code.

@buzaslan129
Copy link
Copy Markdown

buzaslan129 commented May 16, 2026

so good

@Michspirit99
Copy link
Copy Markdown

Michspirit99 commented May 16, 2026

You have a syntax error on line 506,154

@alessiodam
Copy link
Copy Markdown

alessiodam commented May 16, 2026

Can someone request a review from Copilot?

@rigozalli
Copy link
Copy Markdown

rigozalli commented May 16, 2026

Please refactor before merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

35 more reviewers

@qmogh qmogh qmogh left review comments

@Lyroth001 Lyroth001 Lyroth001 left review comments

@mishalzaman mishalzaman mishalzaman left review comments

@Jesperejohannsen Jesperejohannsen Jesperejohannsen approved these changes

@ilnarildarovuch2 ilnarildarovuch2 ilnarildarovuch2 approved these changes

@alexisdrakopoulos alexisdrakopoulos alexisdrakopoulos approved these changes

@setanjan123 setanjan123 setanjan123 approved these changes

@edenchazard edenchazard edenchazard approved these changes

@cosmii02 cosmii02 cosmii02 approved these changes

@OmkarJS OmkarJS OmkarJS approved these changes

@sanchpet sanchpet sanchpet approved these changes

@danblackadder danblackadder danblackadder approved these changes

@svetkomir svetkomir svetkomir approved these changes

@m-m-adams m-m-adams m-m-adams approved these changes

@estnml estnml estnml approved these changes

@SimonTrep SimonTrep SimonTrep approved these changes

@LMojica LMojica LMojica approved these changes

@bobagent37 bobagent37 bobagent37 approved these changes

@veeso veeso veeso approved these changes

@Luchsius Luchsius Luchsius approved these changes

@cyruskelly cyruskelly cyruskelly approved these changes

@Mellurboo Mellurboo Mellurboo approved these changes

@eggy03 eggy03 eggy03 approved these changes

@anbguye anbguye anbguye approved these changes

@SaranshBangar SaranshBangar SaranshBangar approved these changes

@greeenboi greeenboi greeenboi approved these changes

@txssu txssu txssu approved these changes

@My-Bad-2 My-Bad-2 My-Bad-2 approved these changes

@erffy erffy erffy approved these changes

@kasi-otter kasi-otter kasi-otter approved these changes

@YO-WHATS-UP2 YO-WHATS-UP2 YO-WHATS-UP2 approved these changes

@dinesh-git17 dinesh-git17 dinesh-git17 approved these changes

@es-sai-fi es-sai-fi es-sai-fi approved these changes

@gdabu-maven gdabu-maven gdabu-maven approved these changes

@EDM115 EDM115 EDM115 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.