Add configurable next/previous pane keybindings#84
Open
thdxg wants to merge 1 commit into
Open
Conversation
⌘] / ⌘[ cycle projects, so issue #83 asks for a separate, rebindable way to cycle focus through the panes within the current tab. Adds nextPane/previousPane actions (unbound by default) that walk the active tab's panes in tree order with wraparound; the palette, menu bar, and Settings keymaps pick them up automatically via AppCommand.allCases. Closes #83
github-actions
Bot
added
area:state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83.
Why
⌘]/⌘[cycle through projects in Macterm, so the issue asked for a separate, rebindable way to cycle focus through the panes within the current tab.What changed
Adds Next Pane / Previous Pane actions following the existing hotkey patterns:
HotkeyAction— newnextPane/previousPanecases, defaulting to"none"(unbound, likesplitAuto) so they don't clash with any existing shortcut. The user binds them in Settings.AppCommand— matching "Next Pane" / "Previous Pane" commands in the Panes category, linked back to the hotkey actions. This single registration surfaces them in the command palette, menu bar, and Settings keymaps automatically.AppState.cyclePane(forward:projectID:)— walkssplitRoot.allPanes()(tree order) from the focused pane with modulo wraparound; no-op for a single pane. Focus restoration to the NSView rides the existingTerminalPane.updateNSViewpath, same as directional focus.AppCommandActionsandResponders.Notes for reviewers
Tests
Added 4
AppStateTestscases: forward advance in tree order, forward/backward wrap, and single-pane no-op.mise run test,format, andlintall pass.