Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
I think it's time to fully eliminate old sass variables, which must not be used anymore ...
All functions that base and colors files contains, moved to functions file, for the consistency
Contents of
vars-colors.scssandvars-values.scssmoved tocolors.scssandbase.scssrespectivelyImportant
You must manually migrate the functions uses
@use '../base.scss';->@use '~tgui-core/styles/functions.scss' as fn;Or stay on local files
em()&rem()functions now uses css font-size variable instead sass placeholder, which was 12pxNote
Using those functions in css variables, requires wrap it inside
#{}For example:
--some-size: #{fn.em(26px)};Why's this needed?
Less trash code and unused files