Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Convnext achitecture#354

Closed
Lorenzobattistela wants to merge 4 commits into
tensorflow:masterfrom
Lorenzobattistela:convnext-achitecture
Closed

Convnext achitecture#354
Lorenzobattistela wants to merge 4 commits into
tensorflow:masterfrom
Lorenzobattistela:convnext-achitecture

Conversation

@Lorenzobattistela

@Lorenzobattistela Lorenzobattistela commented Aug 19, 2023

Copy link
Copy Markdown
Contributor

Implementing ConvNeXt architecture referred in this paper and #353 .

Possible reviewer: @owenvallis

P.S - i'm still getting some problems when formatting with black for me a bunch of other files non-related to my changes are changed, so i did not commit them.

@Lorenzobattistela

Copy link
Copy Markdown
Contributor Author

Weird Pytest output, locally everything just works (except for one test that i did not mess up either):
image

@owenvallis

Copy link
Copy Markdown
Contributor

Thanks @Lorenzobattistela! Please update the PR so that it's based off the Development branch and is a merge back into Development. I'll try and take a look into the failing test. That seems like there is a mismatch between the layer config we expect in the test and the one we're seeing in your test. This can happen sometimes when TF updates the base class' save config (we likely only want to check the new fields anyways). Can you share what version of TF you're using when the error pops up? Thanks.

@Lorenzobattistela

Copy link
Copy Markdown
Contributor Author

Done @owenvallis . Created a new PR based on the dev branch:
#356

#356

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants