fix: replace SERVICES with TEMPORAL_SERVICES and add service validation#141
Merged
chaptersix merged 3 commits intomainfrom Apr 10, 2026
Merged
fix: replace SERVICES with TEMPORAL_SERVICES and add service validation#141chaptersix merged 3 commits intomainfrom
chaptersix merged 3 commits intomainfrom
Conversation
Update docker-compose-multirole.yaml and tls/tls-full/docker-compose.yml to use the TEMPORAL_SERVICES env var instead of the deprecated SERVICES. Add CI validation to the multirole test job that checks each container is listening on its expected service port and not on any other service's port, using ss -tln inside each container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SERVICESenv var withTEMPORAL_SERVICESincompose/docker-compose-multirole.yamlandtls/tls-full/docker-compose.ymlValidation added
Service role isolation — uses
/proc/net/tcpinside each container to verify:Ringpop membership reachability — for history (6934) and matching (6935):
temporal-admin-toolsontemporal-network, verifying ringpop is bound to the right network interface and not just loopback