fix: context deadline exceeded error in create-namespace.sh init script#137
Closed
Geilokowski wants to merge 1 commit intotemporalio:mainfrom
Closed
fix: context deadline exceeded error in create-namespace.sh init script#137Geilokowski wants to merge 1 commit intotemporalio:mainfrom
Geilokowski wants to merge 1 commit intotemporalio:mainfrom
Conversation
Contributor
|
Thank you for taking a look! I don't think this is the correct fix. see: #142 open an issue or pr if that doesn't do the trick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The create-namespace.sh was adjusted to talk to the temporal server via it's IP instead of the docker compose container / service name.
Why?
Because for some reason outside my understanding, it doesn't work when you use the compose service name. Technically this is probably a bug in the temporal cli itself and should be fixed there. If you can point me in the right direction on where I have to go/check to fix this, I would probably be willing to take a look at that too.
Checklist
Closes [Bug] Default Postgres Docker Compose Namespace Setup Container Not Working #136
How was this tested:
First clone the repo, then run
docker compose -f docker-compose-postgres.yml up -d. I validated that the temporal server is reachable from an application using the Java SDK.