More language edits to resource-based slot suppliers#4286
Open
Sushisource wants to merge 4 commits intomainfrom
Open
More language edits to resource-based slot suppliers#4286Sushisource wants to merge 4 commits intomainfrom
Sushisource wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
jimmyjea
reviewed
Mar 13, 2026
docs/develop/worker-performance.mdx
Outdated
| They provide excellent balance with built-in throttling that ensures the Worker will be cautious when handing out new executor slots. | ||
| - When very low Task completion latency & maximum throughput is important, avoid resourced-based auto-tuning slot suppliers. | ||
| - Reserve auto-tuned resource-based slot suppliers for deployments with workloads that have resource | ||
| usage patterns you don't fully understand, and don't care to. It can offer good-enough performance |
jimmyjea
reviewed
Mar 13, 2026
| - **You want acceptable performance with minimum effort**: | ||
| Resource-based suppliers can provide reasonable performance without the need for profiling your | ||
| workfload. They can be a great way to get started with new workloads. If a workload becomes very | ||
| performance-sensitive, it's worth your time to profile it and choose appropriate fixed-size numbers. |
There was a problem hiding this comment.
i think we should be more explicit:
performance-sensitive, we suggest profiling it and using fixed-size numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Title
Notes to reviewers
┆Attachments: EDU-6042 More language edits to resource-based slot suppliers