feat(database): use different integer types declaration with mysql and postgresql according to field length#1978
Open
DevPandi wants to merge 9 commits intotempestphp:3.xfrom
Open
feat(database): use different integer types declaration with mysql and postgresql according to field length#1978DevPandi wants to merge 9 commits intotempestphp:3.xfrom
DevPandi wants to merge 9 commits intotempestphp:3.xfrom
Conversation
…bytes), integer (4 bytes) and smallint (2 bytes). Tiny INT is SQL.
MrYamous
reviewed
Feb 18, 2026
packages/database/tests/QueryStatements/CreateTableStatementTest.php
Outdated
Show resolved
Hide resolved
brendt
requested changes
Mar 9, 2026
| * Adds an `INTEGER` column to the table. | ||
| */ | ||
| public function integer(string $name, bool $unsigned = false, bool $nullable = false, ?int $default = null): self | ||
| public function integer(string $name, bool $unsigned = false, bool $nullable = false, int $bytes = 4, ?int $default = null): self |
Member
There was a problem hiding this comment.
Can we do it with a union type? int|IntergerBytes $size?
Author
There was a problem hiding this comment.
Good idea, done with next commit.
|
|
||
| namespace Tempest\Database\QueryStatements; | ||
|
|
||
| enum IntegerBytes: int |
Member
There was a problem hiding this comment.
To be consistent, with the other PR, let's call it DatabaseIntegerSize
Author
There was a problem hiding this comment.
Good idea, done with next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #1972
SQLite: "INTEGER. The value is a signed integer, stored in 0, 1, 2, 3, 4, 6, or 8 bytes depending on the magnitude of the value."
PostgreSQL supports SMALLINT, INTEGER and BIGINT.
MySQL supporty TINY*, SMALL*, MEDIUM*, INTEGER and BITINT.
For simplicity's sake: SMALLINT, INTEGER, BIGINT. Less code, less complexity.
I also picked up on the ideas from the suggestion for text types.