Conversation
SOSO-434: Fix getKeyField() lookup to iterate connectionDef.tables by tableDef.tableName instead of schema key name. Add test for schema-name vs table-name distinction. SOSO-435: Replace string-config approach with Strategy-Pattern (UnknownFieldPolicyInterface) analog to SelectorBuilderInterface. Remove warn policy (library stays silent), add delete() coverage, set StripUnknownFieldPolicy as default. Three implementations: Ignore, Strip (default), Error — injectable via DynamicTableFactory.
…ockAppSheetClient
getKeyField() now resolves key fields from ConnectionDefinition instead of
a hardcoded 3-entry map with unsafe 'id' fallback. The lookup iterates
connectionDef.tables values and matches by tableDef.tableName (the real
AppSheet table name), not by schema key name.
Fallback changed from 'id' to convention-based ${tableName}_id.
Closes #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MockAppSheetClient.getKeyField()with schema-based lookup fromConnectionDefinition'id'(non-existent in AppSheet) to convention-based${tableName}_idProblem
getKeyField()used a hardcoded 3-entry map. Tables not in the map (e.g.solution,industry,ideal_customer_profile) silently fell back to'id'— a field that doesn't exist in AppSheet. This caused downstream workarounds inservice_portfolio_mcp(BUG-ASUP-002).Solution
Iterate
Object.values(connectionDef.tables)and match bytableDef.tableName(the real AppSheet table name), not by schema key name. This alignsMockAppSheetClientwith the realAppSheetClientbehavior.Changed Files
src/client/MockAppSheetClient.tsgetKeyField(): schema lookup replaces hardcoded maptests/client/MockAppSheetClient.test.tsgetKeyField() Schema-Lookup (SOSO-434)suiteTest Results
References
docs/SOSO-434/BUGFIX_CONCEPT.md