running: fix watchdog tests with race detector#1252
Open
Conversation
sssciel
force-pushed
the
g.rybakov/tntp-6356-fix-watchdog-data-races
branch
from
2ca8f8e to
2da1c10
Compare
Watchdog tests completed with datarace warning with go test race detector enabled. This was because there was unsafe access to the proccess_controller. Closes TNTP-6356
sssciel
force-pushed
the
g.rybakov/tntp-6356-fix-watchdog-data-races
branch
from
2da1c10 to
27fee44
Compare
psergee
reviewed
Mar 10, 2026
| inst.setTarantoolLog(cmd) | ||
|
|
||
| // Start an Instance. | ||
| inst.mu.Lock() |
Contributor
There was a problem hiding this comment.
The current approach raises questions. We are protecting only a single member of inst, even though the cluster instance employs the exact same process controller initialization code without any locking. Is this a test-specific fix for race conditions, rather than a comprehensive thread‑safety mechanism for the instances API?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watchdog tests completed with datarace warning with go test race detector enabled. This was because there was unsafe access to the proccess_controller.
Closes TNTP-6356