Skip to content

fix(zsh): clear zsh-autosuggestions POSTDISPLAY on forge-accept-line #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolay wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −0
Open

fix(zsh): clear zsh-autosuggestions POSTDISPLAY on forge-accept-line #3244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions shell-plugin/lib/bindings.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,25 @@ bindkey '^M' forge-accept-line
bindkey '^J' forge-accept-line
# Update the Tab binding to use the new completion widget
bindkey '^I' forge-completion # Tab for both @ and :command completion

# Integrate with zsh-autosuggestions.
#
# zsh-autosuggestions wraps widgets listed in ZSH_AUTOSUGGEST_CLEAR_WIDGETS,
# ZSH_AUTOSUGGEST_ACCEPT_WIDGETS, etc. so it can clear POSTDISPLAY (the gray
# inline suggestion) before the widget runs. The wrapping happens once, when
# autosuggestions loads. If Forge's plugin is sourced *after* autosuggestions
# (the Oh-My-Zsh default when users follow `forge zsh setup`), our
# forge-accept-line widget is defined too late to be wrapped, and the inline
# suggestion lingers on the screen after the user presses Enter.
#
# Fix: append forge-accept-line to ZSH_AUTOSUGGEST_CLEAR_WIDGETS and re-run
# the bind pass so the wrapper is installed. Safe no-op when autosuggestions
# is not loaded or when the widget is already registered.
if typeset -p ZSH_AUTOSUGGEST_CLEAR_WIDGETS >/dev/null 2>&1; then
if [[ ${ZSH_AUTOSUGGEST_CLEAR_WIDGETS[(Ie)forge-accept-line]} -eq 0 ]]; then
ZSH_AUTOSUGGEST_CLEAR_WIDGETS+=(forge-accept-line)
if typeset -f _zsh_autosuggest_bind_widgets >/dev/null 2>&1; then
_zsh_autosuggest_bind_widgets
fi
fi
fi
Loading