[CSStep] Skip default Void for closure result in presence of other …#90035
Open
xedin wants to merge 1 commit into
Open
[CSStep] Skip default Void for closure result in presence of other …#90035xedin wants to merge 1 commit into
Void for closure result in presence of other …#90035xedin wants to merge 1 commit into
Conversation
…successful choices `TypeVariableStep::shouldSkip` would always produce `false` in diagnostic mode. This creates unnecessary work for closure result type variables if there is a contextual type available, because `Void` binding would always produce a worse solution in this case due to conversion mismatch with the contextual type and could be safely skipped.
xedin
requested review from
hamishknight,
hborla,
kathygray-pl and
rintaro
as code owners
Contributor
|
Test case? |
Contributor
Author
|
@slavapestov I don’t know how to form one that would test that there is no effect here of not attempting |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test macOS platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…successful choices
TypeVariableStep::shouldSkipwould always producefalsein diagnostic mode. This creates unnecessary work for closure result type variables if there is a contextual type available, becauseVoidbinding would always produce a worse solution in this case due to conversion mismatch with the contextual type and could be safely skipped.