NFC: refactor getRequirementsWithInversesAndOmitted#90026
Merged
Conversation
- Avoids stack space allocation for the common non-printing case of omitting the extra requirements. - Avoids the pattern of passing the same mutable vector twice to the function, instead opting for a boolean and adding them to the existing output vector argument if true.
kavon
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
Member
Author
|
@swift-ci smoke test |
xedin
approved these changes
Jun 17, 2026
Member
Author
|
@swift-ci smoke test macOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids stack space allocation for the common non-printing case of omitting the extra requirements.
Avoids the pattern of passing the same mutable vector twice to the function, instead opting for a boolean and adding them to the existing output vector argument if true.