utils: update Foundation build configuration#90025
Merged
Merged
Conversation
When building Foundation for Android, we need to pass in the path to the OpenSSL libraries now that we build against the custom OpenSSL (BoringSSL) build.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
CC: @finagolfin I missed this in the previous set, it should repair the Android build. |
Member
Author
|
@swift-ci please smoke test Linux platform |
Member
Author
|
@swift-ci please smoke test macOS platform |
Member
|
The Foundation build for Android on the Windows toolchain CI is still failing with this pull applied: That pull is checking trunk using NDK 30 beta 1, but the minimal changes I made shouldn't affect this underlying Foundation config. |
Member
Author
|
Ugh, sorry, not sure how that got through CI in the past. Thanks for pointing that out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building Foundation for Android, we need to pass in the path to the OpenSSL libraries now that we build against the custom OpenSSL (BoringSSL) build.