SwiftArgumentParser: Update to 1.8.1#89404
Conversation
|
@swift-ci smoke test |
|
@swift-ci test |
|
The linux CI is still using a really old pre-installed Swift 5.9.2 to build the early swift driver and this package, which is failing to compile. The newly async failure on mac/win in swift-build I patched locally, will submit that. |
|
@finagolfin : Thanks for publishing PR to the various repositories. |
|
The linux CI builds an early swift driver with this Argument Parser update using a prebuilt Swift 5.9.2, which doesn't recognize new Swift features like typed throws and internal imports in 1.8.0. We'll need to either modify SAP 1.8.1 to keep working with Swift 5.9 or update the host compiler used to bootstrap the toolchain on the linux CI. |
|
Heh, the Docc tests also have async invocations that must be updated. |
bkhouri
force-pushed
the
t/6.4.x/update_sap_to_1.8.0
branch
from
37b2f68 to
4eb4fdf
Compare
bkhouri
changed the title
|
@swift-ci test |
|
Swift Argument Parser (SAP) 1.8.1 fixes a source compatibility regression. I updated the swift toolchain to up version to SAP 1.8.1 instead of 1.8.0 https://github.com/apple/swift-argument-parser/releases/tag/1.8.1 |
Update Swift Argument Parser to use release 1.8.1 to support SE-0501: HTML Coverage report Relates to: swiftlang/swift-package-manager#9076 (cherry picked from commit a914523)
bkhouri
force-pushed
the
t/6.4.x/update_sap_to_1.8.0
branch
from
4eb4fdf to
ab290a6
Compare
|
@swift-ci test |
|
Won't this still fail on linux CI? |
|
Yep, still failing. |
|
I believe this is currently an issue with the base docker image used to build the linux toolchain, which I believe is based on Swift 5.x, while the Swift Argument Parser 1.8.1 has a minimum of Swift 6.0. it might require swiftlang/swift-docker#560, which will need to be thoroughly tested to ensure no regressions are introduced |
Swift Argument Parser 1.8.1 has a minimum requirements of Swift 6.0. Update the Swift Version in the image used to build the Linux Swift toolchain to use Swift 6.0 instead of Swift 5.x Relates to: swiftlang/swift#89403 Relates to: swiftlang/swift#89404
|
@swift-ci test linux |
|
@swift-ci test |
|
You'll need to wait till swiftlang/swift-docker#571 gets in to get the trunk version #89403 in, then this pull depends on if Mishal updates the host compiler in the linux 6.4 CI also. |
3 participants
Update Swift Argument Parser to use release 1.8.0 to support SE-0501: HTML Coverage report
Relates to: swiftlang/swift-package-manager#9076
Cherry-pick #89403
Possibly requires swiftlang/swift-docker#560