Don't build the embedded stdlib or copy the trunk SwiftBridging header on Android CI#569
Open
finagolfin wants to merge 2 commits into
Open
Don't build the embedded stdlib or copy the trunk SwiftBridging header on Android CI#569finagolfin wants to merge 2 commits into
finagolfin wants to merge 2 commits into
Conversation
finagolfin
requested review from
justice-adams-apple and
shahmishal
as code owners
Member
|
I think swiftlang/swift#89753 will unbreak the CI. My other PR doesn't have this fix. |
Member
Author
|
I didn't even really notice we're building embedded till now, so it was pretty stable, 👍 just a waste to keep building it and then throwing it out. If we ever ship an embedded subset for Android, we'll enable this again. |
Member
Author
|
Alright, worked fine locally, ready for review. |
finagolfin
changed the title
Member
Author
|
Added another commit to fix a CI failure when bundling, ready to go in, @justice-adams-apple. |
…ource directory instead, so don't copy it for Android in trunk
finagolfin
changed the title
Member
Author
|
Updated the bridging fix so it should only affect trunk, where this header was moved, swiftlang/swift#88748. |
Member
Author
|
@shahmishal, this will fix the Android CI, ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android CI is broken right now only because we're building the embedded stdlib unnecessarily, and that is currently broken on most linux toolchain CI, swiftlang/swift#89753. Disable it as we just throw out the results anyway.
Let me test this locally and it should be ready to go.