Add a check for null CompUnit in GetTypeFromCU.#13233
Open
jimingham wants to merge 1 commit into
Open
Conversation
This check is present on the llvm.org side, but isn't suitable for a cherry pick because there's a significant refactor between the code on this branch and the code with the fix.
Author
|
This causes a crash if you stop on a frame with no debug info and do |
JDevlieghere
approved these changes
Jun 18, 2026
|
@swift-ci test |
Author
|
The windows test is going to keep failing till: is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check is present on the llvm.org side, but isn't suitable for a cherry pick because there's a significant refactor between the code on this branch and the code with the fix.
I'm also not adding a test because this is just patching this branch, the proper fix is on lldb.org:main.