[lldb][Windows] Enable cxx_interop backward stepping tests#13178
Open
charles-zablit wants to merge 1 commit into
Open
[lldb][Windows] Enable cxx_interop backward stepping tests#13178charles-zablit wants to merge 1 commit into
charles-zablit wants to merge 1 commit into
Conversation
Author
|
@swift-ci please test |
Author
|
ca23ae0 to
ae6eca7
Compare
Author
|
@swift-ci please test |
ae6eca7 to
3ccc858
Compare
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backward interop tests put
main()in C++ (main.cpp) and set a source breakpoint there. Their Makefile assignedCFLAGS = -I. -g, which overrodeMakefile.rules'DEBUG_INFO_FLAGdefault, so on Windows clang emitted CodeView formain.cppwhile the Swift side used DWARF.This patch moves
-I.intoCFLAGS_EXTRASso the default debug flag(-gdwarf on Windows)applies to the C++ main as well.rdar://179241795