Fix broken manual installation instructions#171
Merged
Conversation
kcmartin
force-pushed
the
fix/installation-instructions
branch
from
1253e48 to
9911503
Compare
Contributor
Preview Deployment
Commit: |
Contributor
Lighthouse Results
|
Contributor
E2E Test Results✅ Tests success Ran against: https://pr-171-superfly-sprites-docs.fly.dev |
The checksum verification commands failed because the .sha256 file references a subfolder path (e.g. sprite-darwin-arm64/sprite-darwin-arm64.tar.gz) while the downloaded file is in the current directory. Fixed by piping through awk to extract the hash and pair it with the correct local filename. Also added line continuations to long curl commands to prevent copy-paste issues from visual wrapping, and added error handling to the version fetch. Closes #162
kcmartin
force-pushed
the
fix/installation-instructions
branch
from
a63492d to
42561a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.sha256file references a subfolder path (sprite-darwin-arm64/sprite-darwin-arm64.tar.gz) while the user downloads the file to the current directory\) to longcurlcommands to prevent copy-paste issues from visual line wrappingCloses #162
Testing
Verify on the preview deployment that
/cli/installation/renders code blocks without unintended wrapping and that the commands copy cleanly. The checksum verification command can be validated by running it against a real download.Testing done.