fix: suppress spacing before after manual page breaks#3249
Open
leandrotcawork wants to merge 1 commit into
Open
fix: suppress spacing before after manual page breaks#3249leandrotcawork wants to merge 1 commit into
leandrotcawork wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04d408539c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
04d4085 to
4504c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Word layout fidelity issue where the first real paragraph after an explicit manual page break could render too low in SuperDoc because paragraph
spacingBeforewas still applied at the fresh page top.The change keeps the scope intentionally narrow:
spacingBeforeonly for paragraphs that start a fresh page immediately after an explicit manual page breakpageBreakBeforebehavior, where paragraph spacing should still applyWhy
In Word, an explicit manual page break starts the following paragraph at the top of the new page content area. SuperDoc could retain the following paragraph's
spacingBefore, creating a visible gap above headings or other first-page content after the break.The issue was especially visible in a DOCX fixture with a heading immediately after a manual page break: removing the gap manually in the editor also removed the intended paragraph border/line, which pointed to paragraph spacing/layout state rather than a painter-only issue.
Implementation Notes
pm-adapternow skips fallback empty paragraph creation when the converted paragraph contains only break blocks.layoutDocumentdetects manual page breaks before a target paragraph, including paragraph-anchored images/drawings between the break and the paragraph.layoutParagraphBlocksuppressesspacingBeforeonly when the paragraph is still at the top of a fresh page, before float scans and remeasurement.Reference Document
DC_Template_Descricao_Cargo.docx