SD-3092 - fix: toolbar serialization for stable rendering

packages/template-builder/src/index.tsx

@@ -16,11 +16,11 @@
 type Editor = NonNullable<SuperDoc['activeEditor']>;
 
 const applyDocumentMode = (instance: SuperDoc, mode: string) => {
   (instance as any).setDocumentMode(mode);
 };
 
 const getTemplateFieldsFromEditor = (editor: Editor): Types.TemplateField[] => {
   const structuredContentHelpers = (editor.helpers as any)?.structuredContentCommands;
 
   if (!structuredContentHelpers?.getStructuredContentTags) {
     return [];
@@ -28,7 +28,7 @@
 
   const tags = structuredContentHelpers.getStructuredContentTags(editor.state) || [];
 
   return tags.map((entry: any) => {
     const node = entry?.node ?? entry;
     const attrs = node?.attrs ?? {};
     const nodeType = node?.type?.name || '';
@@ -103,7 +103,10 @@
     const trigger = menu.trigger || '{{';
 
     const availableFields = fieldsRef.current.available || [];
-    const toolbarSettings = useMemo(() => resolveToolbar(toolbar), [toolbar]);
+    // Serialize so structurally-equal toolbar objects compare as equal across
+    // renders — otherwise a fresh inline `toolbar={{...}}` literal would
+    // recreate the SuperDoc instance every parent render.
+    const toolbarSettings = useMemo(() => resolveToolbar(toolbar), [JSON.stringify(toolbar)]);
     const stableTelemetry = useMemo(
       () => ({
         enabled: telemetry?.enabled ?? true,
@@ -386,7 +389,7 @@
             const editor = instance.activeEditor;
             const pe = getPresentationEditor(instance);
 
             editor.on('update', ({ editor: e }: any) => {
               const { state } = e;
               const { from } = state.selection;
 
@@ -403,7 +406,7 @@
                     if (!editor) return;
                     const currentPos = editor.state.selection.from;
                     const tr = editor.state.tr.delete(triggerStart, currentPos);
                     (editor as any).view.dispatch(tr);
                   };
 
                   triggerCleanupRef.current = cleanup;
@@ -572,7 +575,7 @@
         const editor = superdocRef.current?.activeEditor;
         if (!editor) return;
 
         const structuredContentHelpers = (editor.helpers as any)?.structuredContentCommands;
 
         if (!structuredContentHelpers) return;