fix: align rtl toolbar state and alignment writes with ooxml bidi#3244
Open
artem-harbour wants to merge 2 commits into
Open
fix: align rtl toolbar state and alignment writes with ooxml bidi#3244artem-harbour wants to merge 2 commits into
artem-harbour wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66fe33d6ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…i export Adds three coverage layers for the SD-3094 writer-side mirror: - paragraph-alignment unit (23 tests): direct coverage of the new helper pair (mapDisplayAlignmentToStoredJustification + mapStoredJustificationToDisplayAlignment), including the absent-value default and a display->stored->display roundtrip for every alignment. - Toolbar behavior (4 tests): clicking each align button on an RTL paragraph writes the expected mirrored OOXML justification (verified via the doc-api). - Doc-API story (5 tests): format.paragraph.setAlignment on an RTL paragraph exports the expected w:jc value (left->right, right->left, center->center, justify->both); LTR baseline unchanged. Fixture rtl-paragraph-alignment.docx is duplicated from the SD-3093 behavior tests so this PR's CI can run standalone; it will collapse to the SD-3093 copy when the two PRs merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: SD-3094
Fixes RTL paragraph alignment parity across toolbar state and alignment commands.
What changed
left/rightmirroring for RTL,justify↔both).setTextAligncommand to:run),rightToLeft,paragraphsSetAlignmentWrapper,style.apply/spanStyle.applyexecutor logic).Result
Mod-Shift-L/R) apply expected visual alignment in RTL paragraphs.Related: #3235