Add reliability round-cost metrics#692
Conversation
|
Warning Review limit reached
More reviews will be available in 1 minute and 42 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Relay Review Round 2Verdict: CHANGES_REQUESTED |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f9ddc613b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| function classifyEvidenceFailureType({ explicitType, status, reason }) { | ||
| const normalizedType = normalizeFailureTypeText(explicitType); | ||
| if (normalizedType) return normalizedType; |
There was a problem hiding this comment.
Preserve evidence failure detail before using generic types
When processing real review_preflight_failed events emitted by review-runner/preflight.js, stale, invalid, symlink, and strict failures all carry preflight_type=execution_evidence_fail and failure_class=fail; the distinguishing detail is only in reason. Returning the normalized explicit type here prevents the later reason checks from classifying stale/invalid failures, so evidence_preflight_failures.by_type and reviewer_rounds_avoided_by_preflight.by_type collapse those avoided rounds into generic execution_evidence_fail instead of the buckets operators are meant to compare before reviewer invocation.
Useful? React with 👍 / 👎.
Relay ReviewVerdict: LGTM |
Summary
Reissued #684 after the stacked PR base was merged and the original PR #690 became closed against the deleted base branch.
This branch is now rebased directly on
mainand contains the reliability round-cost metrics change only.Changes
round_costsummary toreliability-report.js.Evidence
4f9ddc613b6e30642cd14fe7e117fec94ad38e2enode --test tests/relay-dispatch/scripts/reliability-report.test.jsRelated