Skip to content

Document relay-ready decomposition contract#687

Merged
sungjunlee merged 2 commits into
mainfrom
issue-680-ai-decomposition-contract
Jun 8, 2026
Merged

Document relay-ready decomposition contract#687
sungjunlee merged 2 commits into
mainfrom
issue-680-ai-decomposition-contract

Conversation

@sungjunlee

Copy link
Copy Markdown
Owner

Dispatch Summary

완료했습니다.

변경 사항:
- [decomposition-contract.md](/Users/sjlee/.relay/worktrees/8a7b82fc/dev-relay/skills/relay-ready/references/decomposition-contract.md:1) 추가: script-vs-AI 경계, proposal-first shaping, bounded clarification, planner consumption, #431 범위 구분 문서화
- [relay-ready/SKILL.md](/Users/sjlee/.relay/worktrees/8a7b82fc/dev-relay/skills/relay-ready/SKILL.md:57)에 decomposition boundary 요약 추가
- [relay-plan/SKILL.md](/Users/sjlee/.relay/worktrees/8a7b82fc/dev-relay/skills/relay-plan/SKILL.md:42)에 p

Score Log

  • Run: issue-680-20260608003105658-ef963c5b
  • Executor: codex
  • Branch: issue-680-ai-decomposition-contract

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sungjunlee, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f837b4f1-8549-4886-9277-2bc6dd574d72

📥 Commits

Reviewing files that changed from the base of the PR and between c50f743 and 33f4e41.

📒 Files selected for processing (4)
  • skills/relay-plan/SKILL.md
  • skills/relay-ready/SKILL.md
  • skills/relay-ready/references/decomposition-contract.md
  • tests/relay-ready/scripts/request-store.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-680-ai-decomposition-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sungjunlee

Copy link
Copy Markdown
Owner Author

Relay Review Round 1

Verdict: CHANGES_REQUESTED
Summary: 계약 검토 실패. Done Criteria 상태: VERIFIED script-vs-AI 경계 문서화; PARTIAL strong decomposition proposal-first 운영 흐름은 문서화됐지만 proposal이 leaf-level goal/in-scope/out-of-scope/Done Criteria와 sprint-batch bypass 조건을 요구하지 않음; VERIFIED relay-plan은 relay-ready/.md와 frozen Done Criteria를 source of truth로 소비; VERIFIED multi-leaf depends_on persistence는 기존 schema와 focused test로 확인; VERIFIED oversized product-foundation docs/tests 예시 추가; VERIFIED #431을 older readiness epic으로 참조.
Contract: FAIL
Quality Review: NOT_RUN
Quality Execution: PASS
Issues:

  • skills/relay-ready/references/decomposition-contract.md:20 — Proposal-first workflow omits required leaf-level proposal contract: The new decomposition contract says proposals should include only short AI-authored leaf proposals with order and dependency intent. The planning rubric requires proposal-first shaping to include leaf titles, goals, dependencies, in-scope/out-of-scope, and leaf-level Done Criteria, plus the sprint-batch bypass rule for cases where leaf-level Done Criteria, prompt, rubric, and smoke/replay scenario already exist. The added test mirrors the weaker contract by proposing only leaf names and dependencies before persistence. This leaves the operator workflow underspecified for accepting reviewable decomposition boundaries.

@sungjunlee

Copy link
Copy Markdown
Owner Author

Relay Review

Verdict: LGTM
Summary: Diff overview: 변경 파일은 relay-ready 문서 2개, relay-plan 안내 1개, relay-ready 요청 저장 테스트 1개이며 모두 Done Criteria 범위 안입니다. Done Criteria 검증: VERIFIED script-vs-AI 경계는 relay-ready/SKILL.md 및 decomposition-contract.md에 명시됨; VERIFIED strong decomposition proposal-first 흐름은 leaf title/goal/dependency/in-scope/out-of-scope/leaf-level Done Criteria, bounded clarification, sprint-batch bypass까지 포함함; VERIFIED relay-plan은 relay-ready/.md와 frozen Done Criteria를 source of truth로 소비함; VERIFIED multi-leaf depends_on persistence는 기존 schema와 테스트로 유지됨; VERIFIED oversized product-foundation 예시는 docs/tests 모두 AI-authored proposals를 포함함; VERIFIED #431은 older readiness epic으로만 참조됨. 변경된 테스트 호출부와 relay-request persistence/structure/acceptProposal 경로도 확인했고 통합상 문제는 보이지 않습니다.
Contract: PASS
Quality Review: PASS
Quality Execution: PASS
Rounds: 2

@sungjunlee sungjunlee merged commit 2f4dae7 into main Jun 8, 2026
2 checks passed
@sungjunlee sungjunlee deleted the issue-680-ai-decomposition-contract branch June 8, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant