Closed
Conversation
Refactor to having a single class for syncing Stripe entities - while the class itself is a bit large, it avoids having to do parameter drilling through many methods and actually reduces overall code by quite a bit. Additionally - Reduced boilerplate for backfills (generic function) - Reduced boilerplate for deletions - Reduced boilerplate for auto-expanding lists - Migrated from jest to vitest - Sped up CI - Config option to enable/disable automatic backfills - Configurable max connections - Migrate to pnpm
⛔ Snyk checks have failed. 2 issues have been found so far.
⛔ code/snyk check is complete. 2 issues have been found. (View Details) 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![snyk-io[bot]](https://avatars.githubusercontent.com/in/372950?s=60&v=4){kind=small}
ecktoteckto
approved these changes
Jun 1, 2025
kevcodez
deleted the
kevin/billing-1390-disable-request-logging-and-log-events-in-stripe-sync-engine
branch
tonyxiao
pushed a commit
that referenced
this pull request
Apr 15, 2026
* feat: support non-default sync schema names This lets installs and eval baselines target a configured schema name instead of hard-coding `stripe` in the bootstrap path. It replaces the old migration rewrite flow with explicit SQL placeholders and tests so custom schema names stay safe and repeatable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to having a single class for syncing Stripe entities - while the class itself is a bit large, it avoids having to do parameter drilling through many methods and actually reduces overall code by quite a bit.
Additionally