Adds support for product marketing_features field#134
Merged
kevcodez merged 3 commits intostripe:mainfrom May 23, 2025
Merged
Conversation
kevcodez
reviewed
May 23, 2025
Collaborator
kevcodez
left a comment
kevcodez
left a comment
There was a problem hiding this comment.
Thanks for the contribution, almost there
Please also add the field to https://github.com/supabase/stripe-sync-engine/blob/2864448eae9764ce72ee865287fbac0950e880f7/src/schemas/product.ts#L3 and https://github.com/supabase/stripe-sync-engine/blob/2864448eae9764ce72ee865287fbac0950e880f7/test/helpers/stripe.ts#L554
Contributor
Author
Added the one missing 👍 |
kevcodez
approved these changes
May 23, 2025
|
🎉 This PR is included in version 0.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tonyxiao
pushed a commit
that referenced
this pull request
Apr 15, 2026
Calling validateProject failed on branch projects because the /projects api doesn't return branch projects. While it was possible to get branch projects by getting other api endpoints, it's needlessly complex to just verify if a project exists or not. Intead we omit this call and let the other api calls fail during installation if the project doesn't exist or there are permission issues. Ideally we'd have a token introspection api which can tell us which permissions the current token has, but we don't have such an api endpoint exposed currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds support for the
marketing_featuresfield under the Stripe product entityWhat is the current behavior?
the attribute is missing from the schema
What is the new behavior?
The new field would be parsed from the webhook event