Uses new oauth_login from latest develop branch on gmusicapi#273
Open
fergyfresh wants to merge 11 commits intomasterfrom
Open
Uses new oauth_login from latest develop branch on gmusicapi#273fergyfresh wants to merge 11 commits intomasterfrom
fergyfresh wants to merge 11 commits intomasterfrom
Conversation
fergyfresh
changed the title
update Dockerfile for dev
Adds requirements for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stevenleeg, I reworked this to use the new login feature Simon added to the gmusicapi lib. It works for me, but I wanted to have you review it and see if we wanted to have feature flags or completely deprecate the old login since there were so many issues with it.
I updated the code and the README to re-illustrate how, using this new feature, you don't need to supply any credentials but the hashed device id. This is more secure and a more straight forward way than using the app password imho.
Lemme know if you have any questions.