Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update the Core Advancement Proposals (CAP) table in the README by adding line numbers and protocol versions for three CAP entries (CAP-0074, CAP-0075, and CAP-0076). However, there are critical errors in the protocol version assignments.
Changes:
- Added table row numbers (85, 86, 87) for CAP-0074, CAP-0075, and CAP-0076
- Added protocol versions to these three CAP entries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | [CAP-0075](cap-0075.md) | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | ||
| | [CAP-0076](cap-0076.md) | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | ||
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | |
There was a problem hiding this comment.
The protocol version for CAP-0075 should be 24, not 25. The CAP file (cap-0075.md line 13) specifies "Protocol version: 24".
| | [CAP-0075](cap-0075.md) | 25 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | |
| | [CAP-0075](cap-0075.md) | 24 | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | |
| | [CAP-0074](cap-0074.md) | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | ||
| | [CAP-0075](cap-0075.md) | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | ||
| | [CAP-0076](cap-0076.md) | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | |
There was a problem hiding this comment.
The protocol version for CAP-0074 should be 24, not 25. The CAP file (cap-0074.md line 13) specifies "Protocol version: 24".
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | |
| | [CAP-0074](cap-0074.md) | 24 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | |
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
| | [CAP-0074](cap-0074.md) | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | | ||
| | [CAP-0075](cap-0075.md) | Cryptographic Primitives for Poseidon/Poseidon2 Hash Functions | Jay Geng | Awaiting Decision | | ||
| | [CAP-0076](cap-0076.md) | P23 State Archival bug remediation | Dmytro Kozhevin | Final | | ||
| | [CAP-0074](cap-0074.md) | 25 | Host functions for BN254 | Siddharth Suresh | Awaiting Decision | |
There was a problem hiding this comment.
I had fixed this in #1880. Looks like its in master branch. Maybe you had a stale branch, @tomerweller ?
There was a problem hiding this comment.
ah, nevermind. This PR is old so we can close it since master has the fix.
No description provided.