Add decompressed size limits to snapshot downloads.#2479
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds safety limits around downloading and decompressing history archive snapshot inputs to avoid unbounded decompression during snapshot create, along with a small HTTP client hardening change.
Changes:
- Introduce maximum decompressed-size limits for bucket and ledger header downloads in
snapshot create, with a new error variant when exceeded. - Apply a 30s connection timeout to both async and blocking
reqwestclients.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
cmd/soroban-cli/src/utils.rs |
Adds a shared CONNECT_TIMEOUT and applies it to both async and blocking HTTP clients. |
cmd/soroban-cli/src/commands/snapshot/create.rs |
Enforces decompressed-size caps during gzip streaming to disk and returns a specific error when limits are exceeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add decompressed size limits to snapshot downloads.
Why
To prevent unlimited decompression.
Known limitations
N/A