Skip to content

Patch-1: Correção da chamada da função replace na função overdisp#1

Open
renartius wants to merge 3 commits into
stats-tests:mainfrom
renartius:patch-1
Open

Patch-1: Correção da chamada da função replace na função overdisp#1
renartius wants to merge 3 commits into
stats-tests:mainfrom
renartius:patch-1

Conversation

@renartius
Copy link
Copy Markdown

Ao utilizar a versão 2.1.3 do pandas, ocorre erros de execução (linhas 126 e 128):

re.error: unterminated character set at position 0

E erros de comportamento inesperado (linha 127), onde ao usar replace "." com regex=True toda cadeia de caracteres é substituída por "_".

Gostaria que avaliassem a alteração e caso seja benéfica, aceitem este PR.

Muito obrigado.

Comment thread statstests/pytests/test.py Outdated
"""
Teste para validar alteração
"""
import pytest
Copy link
Copy Markdown

@arcanjoaq arcanjoaq Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please, import pytest outside this function?

Comment thread statstests/pytests/test.py Outdated
Teste para validar alteração
"""
import pytest
import pandas as pd
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please, import pandas outside this function?

Comment thread statstests/pytests/test.py Outdated
@renartius
Copy link
Copy Markdown
Author

changes requested done

@arcanjoaq
Copy link
Copy Markdown

@helderprado Could you please review this PR?

2 similar comments
@arcanjoaq
Copy link
Copy Markdown

@helderprado Could you please review this PR?

@arcanjoaq
Copy link
Copy Markdown

@helderprado Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants