fix: rewrite promote-force e2e to test a real guard force bypasses#122
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
promote-force.yamle2e scenario asserted that a no-op re-promote is rejected by a guard, then thatforcebypasses it. The promote code has no no-op guard that errors: a no-op re-promote is silently skipped and succeeds (SkippedEnvs, "all environments are up to date"). The scenario'sexpect_failurestep therefore tested behavior that does not exist and only ever passed on flaky timing. Isolated, it fails deterministically withexpected promote to fail but it succeeded.Fix
Rewrote the scenario to exercise the one guard
forcegenuinely overrides: the patch-containment guard that protects a diverged environment (internal/promote/preflight.go,checkPatchContainment). The breaking-change gate is bypassed byallow_breaking, notforce, so it is not the right target.The new scenario keeps dev behind trunk, marks test diverged with a later trunk commit as a recorded patch, then:
expect_failure), test unchangedforce: trueoverrides the guard and succeedsAncestry is decided by real git on fully fetched history, so both legs are deterministic. Renamed to "Promote force bypasses the patch-containment guard".
Verification
go build ./...,cd e2e && go vet ./...,golangci-lint run ./e2e/...all clean