test: gen-only e2e scenarios for opt-in workflow generators#114
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Scenario 15 was asserting the substring 'cascade orchestrate setup' which only appears in a Go source comment, never in the generated cascade-merge-queue.yaml. The generator emits 'cascade --dry-run orchestrate setup'; update the assertion to match the real output and also verify the dry-run safety flag is present. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds gen-only e2e scenarios covering the opt-in workflow generators that were
previously not expressible in harness Config.
Changes
Configwith passthrough map fields (validate,validate_check,merge_queue,pr_preview,notify,external) so scenarios can declare them andthe generator emits the corresponding workflows. Generic maps keep the harness
decoupled from the generator struct shapes while preserving every key across the
marshal round-trip.
not_existstoWorkflowFileExpectso scenarios can assert a generated fileis absent (the conditional-generation case).
14-validate-check,15-merge-queue,16-pr-preview,17-validate-callback,hotfix/hotfix-generation-threshold(two envs),hotfix/hotfix-no-hotfix-single-env(one env, asserts absence).Verification
go build ./... && go vet ./...clean in both the root and e2e modules.workflow files.
golangci-lint run ./...clean in the e2e module.