chore(e2e): remove simulation layer and legacy hotfix scenarios#111
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harness.RunWorkflow/RunWorkflowWithSetup,simulatePromote,simulateHotfix,detectErrorConditions,determineNextVersion/determineHotfixVersion,Harness.Assert) and theTestScenariosentry point, so every scenario now runs as a real multi-step test under act + gitea.DiscoverScenariosskip files containingsteps:orrepos:, so a lifecycle scenario is never also parsed as a degenerate single-step run. This halves container load.promote-fails-missing-sourceas real multi-step tests that assert workflow conclusion failure.environment_configpassthrough to the harnessConfigand fixes the env-gates assertion to newline-anchor on the job-level (4-space)environment:key so it no longer matches the 6-space reusable-workflowwith:input.changelog:blocks from scenarios 01/02/03 (never consumed by the assertion layer).compareStatehelper to keep the e2e module lint clean.Verification
go build ./...andgo vet ./...clean on both the root and e2e modules.golangci-lint run ./...clean in the e2e module (0 issues).TestMultiStepScenariosruns pass: single/two env (3), three/four env (3), env-gates + build-failure + missing-workflow + promote-fail (5), and harness unit tests (8).hotfix_branchreferences remain; no duplicate scenario-number prefixes.