Skip to content

Gate Perception suppression to debug#390

Open
johnnewman-square wants to merge 1 commit intomainfrom
johnnewman/task/debug-check
Open

Gate Perception suppression to debug#390
johnnewman-square wants to merge 1 commit intomainfrom
johnnewman/task/debug-check

Conversation

@johnnewman-square
Copy link
Copy Markdown
Contributor

@johnnewman-square johnnewman-square commented Apr 15, 2026

This PR builds on the changes from #389.

Summary

  • gate skipPerceptionChecking behind #if DEBUG via a shared helper
  • apply the debug-only suppression to both readState and child-wrapper access(...)
  • add test_nativeOptionalChildStoreObservation so native observation covers the wrapper path through Store.access(...)
  • include the updated Samples/Tuist/Package.resolved

Why

Perception only consults skipPerceptionChecking from its debug-only checking path, so release builds do not need the TaskLocal wrapper. The new native optional-wrapper test closes the coverage gap in the path that motivated the original suppression.

Test plan

  • Ensure the new test passes
  • Look for regressions on the ObservableComposition app.

Co-authored-by: Codex <codex@openai.com>
@johnnewman-square johnnewman-square force-pushed the johnnewman/task/debug-check branch from 2f21af4 to 9650e23 Compare April 15, 2026 17:15
@johnnewman-square johnnewman-square marked this pull request as ready for review April 15, 2026 17:30
@johnnewman-square johnnewman-square requested review from a team as code owners April 15, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant