GH-3884: Throw clear exception when tool parameter receives empty string from model#6018
Open
suryateja-g13 wants to merge 1 commit into
Open
Conversation
…eives blank string from model
When a model returns a blank or empty string for a numeric tool parameter
(Byte, Short, Integer, Long, Float, Double), JsonParser.toTypedObject()
previously threw a cryptic NumberFormatException. Now throws
IllegalArgumentException with a clear message indicating the expected type.
Boolean and enum types are excluded from the guard: Boolean.parseBoolean("")
returns false by contract, and enum conversion already throws a clear
IllegalArgumentException for unrecognised values.
Fixes spring-projectsGH-3884 (spring-projects#3884)
Signed-off-by: Gorre Surya <suryateja.g13@gmail.com>
suryateja-g13
force-pushed
the
GH-3884-empty-string-tool-param
branch
from
883894a to
6b38c6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a model returns an empty string for a numeric tool parameter (e.g.
Long,Integer,Double,Short),JsonParser.toTypedObject()previously threw a crypticNumberFormatExceptionwith no context about what went wrong.Why
The fix adds an early blank-string guard in
toTypedObject()that throwsIllegalArgumentExceptionwith a clear message indicating the expected type. Empty strings are still allowed forStringtype parameters. Blank strings (whitespace-only) are also caught since they cause the same downstream failure.Changes
JsonParser.toTypedObject()— added blank string guard before numeric conversionJsonParserTests— added 6 new tests covering empty/blank string rejection for numeric types, and empty string passthrough forStringtypeFixes GH-3884 (#3884)