spin-telemetry: use rustls for OTLP HTTP exporter#3462
Open
TheRayquaza wants to merge 1 commit intospinframework:mainfrom
Open
spin-telemetry: use rustls for OTLP HTTP exporter#3462TheRayquaza wants to merge 1 commit intospinframework:mainfrom
TheRayquaza wants to merge 1 commit intospinframework:mainfrom
Conversation
Signed-off-by: Mateo Lelong <mateo.lelong@datadoghq.com>
Collaborator
calebschoepp
left a comment
There was a problem hiding this comment.
From an OTel perspective the changes look fine to me.
Regarding rustls and cert stuff I'm out of my depth and would like some feedback from other maintainers with more knowledge in the area. My gut says that at the very least when there are OS certs we can rely on we should use them over rustls.
| } | ||
|
|
||
| /// Build a reqwest::Client that explicitly uses rustls as the TLS backend. | ||
| /// |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey spin folks 👋
I recently run into the following error when trying to target a https OTEL endpoint:
Tell me If I am wrong:
In minimal OCI containers (distroless, Alpine without ca-certificates), the Spin host process has no system CA bundle, which breaks TLS verification for any component relying on the OS cert store.
Worth noting:
rustls-platform-verifier, the current default for outbound HTTP, also reads the OS store so it probably has the same issue in distroless environments (though I haven't tested it 😄).Would it make sense to make
webpki-rootsthe default or at least an easy fallback ?