Add content-length header attributes to outbound HTTP spans#3459
Open
ChihweiLHBird wants to merge 1 commit intospinframework:mainfrom
Open
Add content-length header attributes to outbound HTTP spans#3459ChihweiLHBird wants to merge 1 commit intospinframework:mainfrom
ChihweiLHBird wants to merge 1 commit intospinframework:mainfrom
Conversation
Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
commented
Apr 14, 2026
Comment on lines
+462
to
+467
| record_content_length_header( | ||
| &span, | ||
| request.headers(), | ||
| "http.request.header.content-length", | ||
| ); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I intentionally put this after interceptor, but I wasn't confident about this decision. I would like to hear more opinion on this.
Collaborator
There was a problem hiding this comment.
Assuming you've manually tested and values look correct this seems fine to me. Before after the interceptor shouldn't matter too much from my understanding.
calebschoepp
approved these changes
Apr 16, 2026
Collaborator
calebschoepp
left a comment
There was a problem hiding this comment.
This change seems reasonable to me. LGTM
Comment on lines
+462
to
+467
| record_content_length_header( | ||
| &span, | ||
| request.headers(), | ||
| "http.request.header.content-length", | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
Assuming you've manually tested and values look correct this seems fine to me. Before after the interceptor shouldn't matter too much from my understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Records
http.request.header.content-lengthandhttp.response.header.content-lengthon outbound HTTP spans when the header is present.Uses
set_attribute()fromtracing_opentelemetry::OpenTelemetrySpanExtbecause the OTel attribute names contain hyphens, whichtracing's#[instrument]field system cannot represent.I didn't implement a test because I thought it's not worth to add another expensive integration test case just for a new field sent to OTel collector.
I used a small HTTP component and otel-desktop-viewer to verify this works as expected:
Addresses part of #3188 (Option 1).
Changes
crates/factor-outbound-http/Cargo.toml— addedtracing-opentelemetrydependencycrates/factor-outbound-http/src/wasi.rs— addedrecord_content_length_headerhelper and call sites for request (after interceptor) and response