Give document types dedicated Finder icons#55
Merged
Merged
Conversation
Generate per-format Finder icons that match FuseX's existing set, so a new file type gets an icon without hand-editing artwork. Reuses blank.icns as the shared base and stamps the uppercase label in Lucida Grande Bold. Run with 'make icon FORMAT=<ext>' from fusepb/.
Every declared ZX Spectrum document type now shows a format-specific Finder icon. Fifteen formats previously fell back to the generic blank icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems solved
blankicon in Finder, so they were visually indistinguishable.blank.What this PR does
Adds
fusepb/format-icon.swift, a generator that takes the sharedblank.icnsas a base and stamps an uppercase label onto each layer, matching the look of the hand-made icons already in the set. Amake icon FORMAT=<ext> [LABEL=<text>]target wraps it. Running it for the 15 remainingblank-mapped formats produces dedicated.icnsfiles, which are wired into the app's Resources build phase, andInfo-FuseX.plistrepoints every affectedCFBundleTypeIconFile/UTTypeIconFilefromblankto its own icon. After this branch no document type still falls back toblank, and adding a new one is a singlemake iconinvocation.Other changes
project.pbxprojcarries incidental Xcode normalizations from adding the icons through the IDE (a dangling build-file comment, a dropped group-name annotation, an addedproductRefGroup, a re-serialized run-script string). None affect the build.