Don't abort launch on an unreadable open argument#50
Merged
Conversation
On cold launch AppKit routes stray command-line arguments to application:openFile:. An argument that is not a readable, identifiable file aborted the launch via fuse_abort, which dereferences NULL in startup_manager_run_end before the startup manager is initialised. Decline such arguments instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On cold launch AppKit routes stray command-line arguments to
application:openFile:. Beforedisplay_ui_initialised, an argument that is not a readable, identifiable file calledfuse_abort(), which dereferences NULL instartup_manager_run_endbecause the startup manager isn't initialised yet. This declines such arguments (return NO) instead.Repro: launch with a stray value-bearing option whose argument AppKit treats as a file to open.
Unpatched
mastercrashes during launch (48is routed toopenFile:, fails to read, aborts). With the fix the app declines48and launches normally.Crash signature on unpatched
master: