Conversation
Updated the pull request template to clarify the risks section and added a note about manual testing requirements.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the PULL_REQUEST_TEMPLATE.md by consolidating the 'Risks' and 'Manual testing done' sections into a single 'Risks / Testing' section. The feedback suggests refining the placeholder text to require risk assessment and manual testing details for all pull requests, rather than only those immediately affecting production, to ensure consistent safety and audit trails.
| ## Manual testing done | ||
| ## Risks / Testing | ||
|
|
||
| [ This must be filled in, if this will immediately affect production i.e. this code will be used when it is rolled out. Otherwise the project test plan should cover this. ] |
There was a problem hiding this comment.
The conditional instruction 'if this will immediately affect production' is ambiguous and potentially risky. Even if a change is not immediately active (e.g., behind a feature flag), it still introduces code into the production environment and should be verified. Requiring this section for all pull requests ensures better visibility, safety, and a consistent audit trail.
| [ This must be filled in, if this will immediately affect production i.e. this code will be used when it is rolled out. Otherwise the project test plan should cover this. ] | |
| [ Describe the potential risks of this change and the manual testing performed to verify it. This section should be completed for all pull requests to ensure code quality and production stability. ] |
2 participants
Updated the pull request template to clarify the risks section and added a note about manual testing requirements.
Changes summary
Risks
Manual testing done