Fix incorrect numSplats in lod-on-demand example#311
Open
mrxz wants to merge 1 commit intosparkjsdev:mainfrom
Open
Fix incorrect numSplats in lod-on-demand example#311mrxz wants to merge 1 commit intosparkjsdev:mainfrom
mrxz wants to merge 1 commit intosparkjsdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing the "Change non-LoD splat colors" button while the LoD splats were being shown, only a subset of the underlying splat colours were changed. This was caused by the fact that
SplatMesh.numSplatsreflects the number of splats being rendered with LoD enabled (SplatMesh#L861), not the total amount of splats in the mesh.This PR also increases the upper bound for the
lodSplatCountslider. This way the user can increase it all the way up to the number of splats of the original splat file. Before the example always showed a reduced LoD version, even when cranking up the amount. Worst case this could lead people to believe an inherent reduction in visual quality when enabling/generating LoD.