improve large coordinate precision issue#302
Open
WilliamLiu-1997 wants to merge 1 commit intosparkjsdev:mainfrom
Open
improve large coordinate precision issue#302WilliamLiu-1997 wants to merge 1 commit intosparkjsdev:mainfrom
WilliamLiu-1997 wants to merge 1 commit intosparkjsdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relate to #287
Summary
Improve far-from-origin precision for transformed
SplatMeshscenes by rebasing internal splat generation, accumulation, and sorting to view-relative coordinates.Internally, splat centers are no longer propagated as long-lived absolute world-space values by default. The pipeline now prefers centers relative to the current
viewOrigin/ accumulator origin and only converts back to world space where external semantics require it.What Changed
viewOriginfor both packed and extended splat pathsSparkRendererSplatMeshgeneration before large world translations lose precisionHere are examples:
Example that fixed precision issue
https://threejs-3d-tiles-renderer-mynn6oxso-williamliu1997s-projects.vercel.app/
Example that current Spark has (you can see model is flickering)
https://threejs-3d-tiles-renderer-7rj9n6oeu-williamliu1997s-projects.vercel.app/