fix: rename log-depth shader define and bump three to 0.183.2#290
fix: rename log-depth shader define and bump three to 0.183.2#290JodokGBS wants to merge 3 commits intosparkjsdev:mainfrom
Conversation
|
Thanks. Is this applicable to https://github.com/sparkjsdev/spark/tree/v2.0.0-preview branch? |
No as far as i can see, this PR is not needed for v2 as it has no #ifdef USE_LOGDEPTHBUF. |
|
Hi @JodokGBS , thanks for your PR! Indeed in v2.0.0-preview branch this is unnecessary because it doesn't use v2.0.0-preview has a minimum Three.js version 0.180.0. I see your PR upgrades it to a newer version, but I think we'd prefer to leave it. There are other unrelated changes in the PR in the commit handle nullable texture data for three 0.183 typings - I'm not sure I follow why this is needed? |
|
Hi @asundqui Thanks for taking the time to look into this PR. The nullable texture changes were only a TypeScript compatibility fix after bumping Given that |
Summary
USE_LOGDEPTHBUFtoUSE_LOGARITHMIC_DEPTH_BUFFERinsrc/shaders/splatVertex.glsl.threefrom^0.178.0to^0.183.2inpackage.json(devDependenciesandpeerDependencies).package-lock.jsonfor the dependency bump.Why
USE_LOGDEPTHBUFwas renamed upstream in Three.js. This keeps Spark compatible with newer Three.js versions.