Skip to content

Fix jsonschema.json paths in resolve being incorrectly relative to path#716

Merged
jviotti merged 2 commits intomainfrom
fail-config-dialect-id
Apr 6, 2026
Merged

Fix jsonschema.json paths in resolve being incorrectly relative to path#716
jviotti merged 2 commits intomainfrom
fail-config-dialect-id

Conversation

@jviotti
Copy link
Copy Markdown
Member

@jviotti jviotti commented Apr 6, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

@jviotti jviotti force-pushed the fail-config-dialect-id branch from 4f8d028 to da694ce Compare April 6, 2026 18:49
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the fail-config-dialect-id branch from da694ce to f69ef04 Compare April 6, 2026 18:55
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the fail-config-dialect-id branch from 919fdeb to 13c8f51 Compare April 6, 2026 19:13
@jviotti jviotti changed the title [WIP] Fix resolution bug on jsonschema.json resolve with $id Fix jsonschema.json paths in resolve being incorrectly relative to path Apr 6, 2026
@jviotti jviotti marked this pull request as ready for review April 6, 2026 19:14
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/configuration.h">

<violation number="1" location="src/configuration.h:71">
P2: `JSONParseError` from `parse_json` is no longer caught/wrapped, so malformed configuration files can escape this function without file-context error wrapping.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread src/configuration.h
@jviotti jviotti merged commit cbd74f7 into main Apr 6, 2026
14 checks passed
@jviotti jviotti deleted the fail-config-dialect-id branch April 6, 2026 19:25
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Apr 8, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | minor | `v14.18.0` → `v14.20.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary>

### [`v14.20.2`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.20.2)

[Compare Source](sourcemeta/jsonschema@v14.20.1...v14.20.2)

#### What's Changed

- Promote Sourcemeta One in the README by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;717](sourcemeta/jsonschema#717)
- Fix NPM publishing of the Blaze evaluator JavaScript port by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;718](sourcemeta/jsonschema#718)

**Full Changelog**: <sourcemeta/jsonschema@v14.20.1...v14.20.2>

### [`v14.20.1`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.20.1)

[Compare Source](sourcemeta/jsonschema@v14.20.0...v14.20.1)

#### What's Changed

- Print a warning when commands implicitly apply to the current working directory by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;712](sourcemeta/jsonschema#712)
- Print a warning given a `jsonschema.json` without an explicit path by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;715](sourcemeta/jsonschema#715)
- Test the `compile` command against the JS Blaze port by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;714](sourcemeta/jsonschema#714)
- Fix `jsonschema.json` paths in `resolve` being incorrectly relative to `path` by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;716](sourcemeta/jsonschema#716)

**Full Changelog**: <sourcemeta/jsonschema@v14.20.0...v14.20.1>

### [`v14.20.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.20.0)

[Compare Source](sourcemeta/jsonschema@v14.19.0...v14.20.0)

#### What's Changed

- Support dynamic references and `patternProperties` in the `codegen` command by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;711](sourcemeta/jsonschema#711)

**Full Changelog**: <sourcemeta/jsonschema@v14.19.0...v14.20.0>

### [`v14.19.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.19.0)

[Compare Source](sourcemeta/jsonschema@v14.18.0...v14.19.0)

#### What's Changed

- Add linter rules for `http`/`https` incorrect schemes in dialects by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;708](sourcemeta/jsonschema#708)
- Support official dialects with both `http://` and `https://` by [@&#8203;jviotti](https://github.com/jviotti) in [#&#8203;709](sourcemeta/jsonschema#709)

**Full Changelog**: <sourcemeta/jsonschema@v14.18.0...v14.19.0>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDQuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwNC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant