upgrade: websocket package upgrade for Solid 2.0#847
Draft
davedbase wants to merge 3 commits intosolidjs-community:nextfrom
Draft
upgrade: websocket package upgrade for Solid 2.0#847davedbase wants to merge 3 commits intosolidjs-community:nextfrom
davedbase wants to merge 3 commits intosolidjs-community:nextfrom
Conversation
🦋 Changeset detectedLatest commit: 4dde890 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the websocket primitive to
solid-js@^2.0.0-beta.7and introduces a new reactive message primitive.Breaking changes
solid-js@^2.0.0-beta.7createEffectdoc examples updated to the Solid 2.0 split form:createEffect(compute, effect)New:
createWSMessage<T>Reactive
Accessor<T | undefined>that holds the latest received WebSocket message. Cleans up its event listener on owner disposal viaonCleanup.createWSStatefixInternal signal now uses
{ ownedWrite: true }to suppress the Solid 2.0 dev-modeSIGNAL_WRITE_IN_OWNED_SCOPEwarning, which fires whenws.close()is called from inside a component or reactive scope.Planned (documented, not yet implemented)
wsMessageIterable<T>— bufferedAsyncIterablefor burst-safe message processingcreateWSData<T>— async memo over the iterable; suspends<Loading>until first messagecreateWSStore<T>— store driven by WS messages as draft-mutation patches