added Meeting object - for review #6

tgra · 2026-02-09T22:42:08Z

Reference https://github.com/SolidOS/meeting-pane/blob/4a180ebdcbbda2210b0117a058672392fa494079/src/meetingDetailsForm.ttl

matthieubosquet · 2026-02-10T10:06:56Z

src/mod.ts

 export * from "./acp/mod.js"
 export * from "./solid/mod.js"
 export * from "./webid/mod.js"
+


Suggested change

matthieubosquet · 2026-02-10T10:07:13Z

src/vocabulary/mod.ts

 export * from "./rdfs.js"
 export * from "./solid.js"
 export * from "./vcard.js"
+export * from "./ical.js"


Suggested change

export * from "./ical.js"

export * from "./ical.js"

matthieubosquet · 2026-02-10T10:07:31Z

src/vocabulary/ical.ts

  dtstart: "http://www.w3.org/2002/12/cal/ical#dtstart",
  location: "http://www.w3.org/2002/12/cal/ical#location",
  summary: "http://www.w3.org/2002/12/cal/ical#summary",
+  vevent: "http://www.w3.org/2002/12/cal/ical#Vevent"


Suggested change

vevent: "http://www.w3.org/2002/12/cal/ical#Vevent"

Vevent: "http://www.w3.org/2002/12/cal/ical#Vevent"

matthieubosquet · 2026-02-10T10:07:46Z

src/solid/mod.ts

 export * from "./Container.js"
 export * from "./ContainerDataset.js"
 export * from "./Resource.js"
+export * from "./Meeting.js"


Suggested change

export * from "./Meeting.js"

export * from "./Meeting.js"

matthieubosquet · 2026-02-10T10:23:32Z

src/solid/Meeting.ts

+export class MeetingDataset extends DatasetWrapper {
+    get meeting(): Iterable<Meeting> {
+        return this.instancesOf(ICAL.vevent, Meeting)
+    }
+}


This should live in its own file: MeetingDataset.ts.

Also, fix capitalisation (reflects further review comments):

Suggested change

export class MeetingDataset extends DatasetWrapper {

get meeting(): Iterable<Meeting> {

return this.instancesOf(ICAL.vevent, Meeting)

}

}

export class MeetingDataset extends DatasetWrapper {

get meeting(): Iterable<Meeting> {

return this.instancesOf(ICAL.Vevent, Meeting)

}

}

It would be interesting to add a link to ical to justify why we use classification based selection (no properties used in the context of this "shape" actually has only domain Vevent: https://www.w3.org/2002/12/cal/ical.n3).

And maybe consider actually using a union pattern with subjectof the various used properties (because in this context, we might only use the properties for Vevents).

Example:

const subjects = new Set([ ...this.instancesOf(ACP.AccessControlResource, AccessControlResource), ...this.subjectsOf(ACP.resource, AccessControlResource), ...this.subjectsOf(ACP.accessControl, AccessControlResource), ...this.subjectsOf(ACP.memberAccessControl, AccessControlResource) ])

Corollary: If tdf:type is the chosen modelling paradigm (and I don't agree that it should be, I would prefer usage based classification) then the mapping class should enable consumers to read/write its type.

See https://github.com/solid/object/blob/main/src/acp/Typed.ts for a pattern for working with type statements.

matthieubosquet · 2026-02-10T10:30:24Z

test/unit/meeting.test.ts

+<https://example.org/meeting/1> a cal:Vevent ;
+
+    cal:summary "Team Sync" ;
+    cal:location "Zoom Room 123" ;
+    cal:comment "Discuss project updates" ;
+    cal:dtstart "2026-02-09T10:00:00Z"^^xsd:dateTime ;
+    cal:dtend "2026-02-09T11:00:00Z"^^xsd:dateTime .


I know that is what corresponds to the current shape in the pane.

However, could you find a few slightly more comprehensive ical events examples so that we create a class that might be a bit more usable?

I wonder if we can get at least the properties corresponding to the main fields in all well known calendar systems. See maybe RFC5545 section 4 for examples.

langsamu · 2026-02-10T15:23:47Z

test/unit/meeting.test.ts

+    });
+
+
+
+});


Suggested change

});

});

});

});

langsamu · 2026-02-10T15:24:51Z

test/unit/meeting.test.ts

+import { describe, it } from "node:test"
+
+import { MeetingDataset } from "@solid/object";
+
+
+describe("MeetingDataset / Meeting tests", () => {
+
+    const sampleRDF = `


Suggested change

import { describe, it } from "node:test"

import { MeetingDataset } from "@solid/object";

describe("MeetingDataset / Meeting tests", () => {

const sampleRDF = `

import { describe, it } from "node:test"

import { MeetingDataset } from "@solid/object";

describe("MeetingDataset / Meeting tests", () => {

const sampleRDF = `

langsamu · 2026-02-10T15:25:43Z

test/unit/meeting.test.ts

+        // Check property types and values
+
+        assert.equal(meeting.summary, "Team Sync");


Suggested change

// Check property types and values

assert.equal(meeting.summary, "Team Sync");

// Check property types and values

assert.equal(meeting.summary, "Team Sync");

langsamu · 2026-02-10T15:26:55Z

test/unit/meeting.test.ts

+        assert.equal(meeting.comment, "Discuss project updates");
+
+
+        assert.ok(meeting.startDate instanceof Date);


Suggested change

assert.equal(meeting.comment, "Discuss project updates");

assert.ok(meeting.startDate instanceof Date);

assert.equal(meeting.comment, "Discuss project updates");

assert.ok(meeting.startDate instanceof Date);

langsamu · 2026-02-10T15:27:35Z

test/unit/meeting.test.ts

+    });
+
+
+
+    it("should allow setting of meeting properties", () => {


Suggested change

});

it("should allow setting of meeting properties", () => {

});

it("should allow setting of meeting properties", () => {

langsamu · 2026-02-10T15:28:54Z

test/unit/meeting.test.ts

+        assert.ok(meeting.endDate instanceof Date, "endDate should be a Date");
+
+    });
+
+
+    it("should ensure all properties are unique text or date values", () => {
+
+        const duplicateRDF = `


Suggested change

assert.ok(meeting.endDate instanceof Date, "endDate should be a Date");

});

it("should ensure all properties are unique text or date values", () => {

const duplicateRDF = `

assert.ok(meeting.endDate instanceof Date, "endDate should be a Date");

});

it("should ensure all properties are unique text or date values", () => {

const duplicateRDF = `

langsamu · 2026-02-10T15:33:45Z

src/solid/Meeting.ts

+export class MeetingDataset extends DatasetWrapper {
+    get meeting(): Iterable<Meeting> {
+        return this.instancesOf(ICAL.vevent, Meeting)
+    }
+}


Corollary: If tdf:type is the chosen modelling paradigm (and I don't agree that it should be, I would prefer usage based classification) then the mapping class should enable consumers to read/write its type.

See https://github.com/solid/object/blob/main/src/acp/Typed.ts for a pattern for working with type statements.

langsamu · 2026-02-10T15:34:19Z

src/solid/Meeting.ts

+    }
+
+}


Suggested change

}

}

}

}

langsamu · 2026-02-10T15:34:42Z

src/solid/Meeting.ts

+import {  ICAL } from "../vocabulary/mod.js"
+
+
+export class MeetingDataset extends DatasetWrapper {


Suggested change

import { ICAL } from "../vocabulary/mod.js"

export class MeetingDataset extends DatasetWrapper {

import { ICAL } from "../vocabulary/mod.js"

export class MeetingDataset extends DatasetWrapper {

langsamu · 2026-02-10T15:40:41Z

test/unit/meeting.test.ts

I think that it would be worth considering a test pattern for mutations where

Test has some RDF in Turtle

RDF is is loaded into a dataset

Dataset is wrapped by mapping classes

Instances of wrappers are mutated

Actual dataset is asserted to be isomorphic with an expected dataset

This is more robust in a way because it does not rely on ther wrappers for reading out values modified by the wrapper itself.

Tanya Gray added 3 commits February 9, 2026 13:44

add Meeting object

f3d8886

add meeting test

fc6b44a

add test for unique non array values

36dec9b

tgra requested review from langsamu and matthieubosquet as code owners February 9, 2026 22:42

matthieubosquet reviewed Feb 10, 2026

View reviewed changes

langsamu requested changes Feb 10, 2026

View reviewed changes

	vevent: "http://www.w3.org/2002/12/cal/ical#Vevent"
	Vevent: "http://www.w3.org/2002/12/cal/ical#Vevent"

-    });
-});
+    });
+});

		// Check property types and values

		assert.equal(meeting.summary, "Team Sync");

		assert.equal(meeting.comment, "Discuss project updates");


		assert.ok(meeting.startDate instanceof Date);

-    }
-}
+    }
+}

		import { ICAL } from "../vocabulary/mod.js"


		export class MeetingDataset extends DatasetWrapper {

		});



		}); No newline at end of file

added Meeting object - for review #6

Are you sure you want to change the base?

added Meeting object - for review #6

Conversation

tgra commented Feb 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants