Open
Conversation
bdjilka
changed the title
bdjilka
force-pushed
the
feature/ffc_api
branch
2 times, most recently
from
3b5322c to
4eced8d
Compare
bdjilka
force-pushed
the
feature/ffc_api
branch
from
4eced8d to
b57bdf0
Compare
ffaraone
requested changes
Apr 21, 2026
Collaborator
There was a problem hiding this comment.
I understand that the whole ClickHouse package will be moved outside to a shared library. I'm saying so just because we should choose a better name like expenses. Definitively, we access also mongo from the code contained into this package.
Author
There was a problem hiding this comment.
Agree. Package will be moved, but as you know it can take a significant amount of time
|
|
||
| settings = get_settings() | ||
|
|
||
| if not secrets.compare_digest(secret, settings.cluster_secret): # type: ignore[type-var] |
Collaborator
There was a problem hiding this comment.
I love this compare_digest, security PRO, do you know if Hystax guys are also using it in their components?
Great job 🥇
Author
There was a problem hiding this comment.
Unfortunately that use simple comparison for secret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue number
Special notes
Checklist