feat: parallelize container monitor dependency requests#6748
Draft
feat: parallelize container monitor dependency requests#6748
Conversation
Co-authored-by: bgardiner <bgardiner@users.noreply.github.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR improves performance for ecosystem/container monitoring by changing the
/monitor-dependenciesrequest flow from fully sequential to hybrid execution:ScanResultrequest first (base OS project ordering retained)ScanResultrequests in parallelAuthFailedErrorMonitorErrorWhere should the reviewer start?
src/lib/ecosystems/monitor.tstest/jest/unit/ecosystems-monitor-docker.spec.tsHow should this be manually tested?
npm run test:unit -- --runTestsByPath test/jest/unit/ecosystems-monitor-docker.spec.tssnyk container monitor <image>What's the product update that needs to be communicated to CLI users?
Container monitor execution is now faster for images that produce multiple scan results. The CLI now keeps base OS processing first and parallelizes the remaining dependency API requests.
Risk assessment (Low | Medium | High)?
Low. This is a scoped orchestration change with focused tests that verify ordering and existing error semantics.
Any background context you want to provide?
Large images that produce many scan results can experience long monitor durations due to sequential API calls; this change addresses that bottleneck.
What are the relevant tickets?
N/A