Skip to content

chore: Release 1.1304.1#6744

Open
mihaibuzgau wants to merge 13 commits intorelease/1.1304from
release-candidate
Open

chore: Release 1.1304.1#6744
mihaibuzgau wants to merge 13 commits intorelease/1.1304from
release-candidate

Conversation

@mihaibuzgau
Copy link
Copy Markdown
Contributor

Release 1.1304.1

@mihaibuzgau mihaibuzgau requested review from a team as code owners April 24, 2026 08:26
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 24, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Extension Promotion 🟡 [minor]

Moving secrets.Init outside the PREVIEW_FEATURES_ENABLED check in initExtensions enables the secrets extension for all users. This represents a graduation from preview to stable; ensure all downstream dependencies in github.com/snyk/cli-extension-secrets are verified for general availability.

engine.AddExtensionInitializer(secrets.Init)
Behavioral Change 🟡 [minor]

In decorateError, the logic was changed from joining errors to using WithCause. While this creates a cleaner single-error chain, it changes how multi-error inspection works for consumers that don't recursively check causes. In-file context shows iterErrorChain exists, which mitigates display issues, but other internal consumers using errors.Unwrap on joined errors will see a change in topology.

genericError := cli.NewGeneralCLIFailureError(err.Error(), snyk_errors.WithCause(err))
return genericError
📚 Repository Context Analyzed

This review considered 54 relevant code sections from 12 files (average relevance: 0.96)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants