Match Net::USERHandler::update()#306
Open
chrisking1981 wants to merge 1 commit into
Open
Conversation
100% byte-match (relax-reloc) for the update method declared in USER.hpp. The function checks NetManager::hasFoundMatch() and dispatches to internal helpers fn_1_152498/fn_1_152B08 (still unmatched, declared extern "C" so the asm fallback resolves them). Verified: - objdiff-cli with -x flag: 100% match - Full build still produces correct main.dol/StaticR.rel sha1
| } else { | ||
| if (*(u8*)this != 0) { | ||
| *(u8*)this = 0; | ||
| *(u32*)((char*)this + 0x9e0) = 0; |
There was a problem hiding this comment.
Please use class memebers instead of direct casts
| } | ||
| } | ||
| if (*(u8*)this != 0) { | ||
| fn_1_152B08(this); |
There was a problem hiding this comment.
could this be a member function of USERHandler?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 100% byte-matching implementation for
Net::USERHandler::update()(declared insrc/net/packets/USER.hppbut not yet defined).The method checks
NetManager::getInstance()->hasFoundMatch():Internal helpers
Calls
fn_1_152498andfn_1_152B08(forward-declaredextern "C"). These don't yet have proper names — they continue to be provided via the asm fallback. Once those get matched + named in a follow-up, theextern "C"declarations can be replaced.Test plan
objdiff-cli -x update__Q23Net11USERHandlerFv: 100% match (relaxed reloc — only the call targets to unmatched helpers differ in symbol naming, machine code is byte-identical)main.dolsha1ac7d72448630ade7655fc8bc5fd7a6543cb53a49StaticR.relsha1887bcc076781f5b005cc317a6e3cc8fd5f911300🤖 Generated with Claude Code